[PATCH] Add wpa_supplicant_notify_scanning() if scan is canceled

[Dmitry Shmidt]

Hi Jouni.

It is hard to catch "in purpose" with the log, so I'll try to explain the
case.

Network manager is issuing scan request through API (it does it periodically
for different reasons).
Meanwhile wpa_supplicant is in the "process" of association.
Driver got scan request and immediately association request.
Driver FW may (and in our case will) cancel previous scan request.
Wlan will be associated, BUT wpa_s->scanning will be set to 1 and will be
left as is.
Network manager may be confused that it didn't get SCAN_RESULTS and didn't
get wpa_s->scanning change
notification.

Thanks,

Dmitry

On Sat, Mar 6, 2010 at 12:56 AM, Jouni Malinen <j at w1.fi> wrote:

> On Fri, Feb 26, 2010 at 10:49:08AM -0800, Dmitry Shmidt wrote:
>
> > There is a situation when scan was scheduled but during association it
> was
> > canceled.
> > And we need to change wpa_s->scanning var and notify network manager.
>
> Could you please describe the case where this would be needed in more
> detail or  send me a debug log (with -ddt on command line) showing a
> case where the scanning is indicated, but not cleared?
>
> The code here is canceling the pending scan _request_, not the scan
> itself and as such, wpa_supplicant_notify_scanning(wpa_s, 1) should not
> have been called yet and as such, there should be no need to call
> wpa_supplicant_notify_scanning(wpa_s, 0) either.
>
> --
> Jouni Malinen                                            PGP id EFC895FA
> _______________________________________________
> HostAP mailing list
> HostAP at lists.shmoo.com
> http://lists.shmoo.com/mailman/listinfo/hostap
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.shmoo.com/pipermail/hostap/attachments/20100308/c70554e7/attachment.htm