[PATCH] hostapd: enable STBC only for STBC capable STAs

[Helmut Schaa]

Any comments regarding this patch?

Thanks,
Helmut

Am Freitag 28 Mai 2010 schrieb Helmut Schaa:
> hostapd simply used its own STBC configuration in the STAs ht caps. This
> resulted in TX STBC being used for STAs not supporting RX STBC, wich in turn
> resulted in the STA not receiving anything.
> 
> Fix this by handling the STBC flags in the same way mac80211 does. Mask out
> RX STBC if we don't support TX STBC and vice versa.
> 
> Tested only with the nl80211 driver and a STBC incapable STA.
> 
> Signed-off-by: Helmut Schaa <helmut.schaa at googlemail.com>
> ---
>  src/ap/ieee802_11_ht.c |   12 ++++++++++--
>  1 files changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/src/ap/ieee802_11_ht.c b/src/ap/ieee802_11_ht.c
> index 1b39a6a..b193ee0 100644
> --- a/src/ap/ieee802_11_ht.c
> +++ b/src/ap/ieee802_11_ht.c
> @@ -256,7 +256,15 @@ void hostapd_get_ht_capab(struct hostapd_data *hapd,
>  	cap &= hapd->iconf->ht_capab;
>  	cap |= (hapd->iconf->ht_capab & HT_CAP_INFO_SMPS_DISABLED);
>  
> -	/* FIXME: Rx STBC needs to be handled specially */
> -	cap |= (hapd->iconf->ht_capab & HT_CAP_INFO_RX_STBC_MASK);
> +	/*
> +	 * STBC needs to be handled specially
> +	 * if we don't support RX STBC, mask out TX STBC in the STA's HT caps
> +	 * if we don't support TX STBC, mask out RX STBC in the STA's HT caps
> +	 */
> +	if (!(hapd->iconf->ht_capab & HT_CAP_INFO_RX_STBC_MASK))
> +		cap &= ~HT_CAP_INFO_TX_STBC;
> +	if (!(hapd->iconf->ht_capab & HT_CAP_INFO_TX_STBC))
> +		cap &= ~HT_CAP_INFO_RX_STBC_MASK;
> +
>  	neg_ht_cap->ht_capabilities_info = host_to_le16(cap);
>  }
>