[PATCH] WPS: reset ClientTimeout to 30 seconds in eap_wsc_init

Jouni Malinen j
Tue Dec 28 02:14:54 PST 2010


On Mon, Dec 20, 2010 at 12:40:42PM -0800, Jason Young wrote:
> Commit 9301f651 reduces ClientTimeout from 30 seconds to 2 seconds
> whenever provisioning step has been completed (either successfully or
> unsuccessfully). Subsequent attempts to complete provisioning may
> prematurely timeout and fail because ClientTimeout is never reset back
> to 30 seconds.

Thanks for reporting this. The issue is valid, i.e., ClientTimeout
changes from an EAP method are not supposed to affect other EAP methods
or even other runs of the same method. However, the proposed change for
eap_wsc.c is not suitable to address the issue; the code there is fine,
the main EAP state machine implementation is the place that is broken. I
fixed this with commit d3e01b9d71046cdf77e4ff4ee6226c9d90d2e549.

-- 
Jouni Malinen                                            PGP id EFC895FA



More information about the Hostap mailing list