[PATCH] DBus: publish keys in network properties

Johannes Berg johannes
Fri Dec 17 08:43:48 PST 2010


On Fri, 2010-12-17 at 18:39 +0200, Jouni Malinen wrote:
> On Fri, Dec 17, 2010 at 03:33:54PM +0100, Johannes Berg wrote:
> > When the network was provisioned, we need to
> > get the keys to be able to reconnect without
> > new provisioning.
> 
> > -	char **props = wpa_config_get_all(net->ssid, 0);
> > +	char **props = wpa_config_get_all(net->ssid, 1);
> 
> I did not like the idea of wpa_config_get_all() much when it was added
> and the main reason that it got it was in disabling the fetching of the
> key part.. This would be reverting that.
> 
> Can we limit this to networks provisioned with WPS/P2P or provide a
> different mechanism for getting the provisioned information to external
> programs without exposing keys that are configured in wpa_supplicant
> configuration?

Yes, I suppose we could limit it to provisioned networks -- but is it
worth it, and can we easily tell the difference? I think we only expose
the DBus interface to root, presumably root can read the config file
anyway, or "remember" what was configured before over DBus?

johannes




More information about the Hostap mailing list