[PATCH 1/3] Added wpa_config_get_all function

Jouni Malinen j
Wed Nov 11 07:21:20 PST 2009

On Tue, Nov 10, 2009 at 04:18:04PM +0100, Witold Sowa wrote:

> The original patch doesn't introduce access to full config, but to
> non-secret config entries only, but it can be easily changed (second
> argument in wpa_config_get_all).

Now that I looked at this, the latest version of the new dbus code is
also using get_keys=0. As such, I don't think WPS would work with this
version. Am I missing something?

> In both scenarios we actually give access to secret data to root
> applications (via config or via WPS credentials), so I think that there
> is no big difference and we should choose full config access since it is
> cleaner solution.

I did end up applying the patch to introduce wpa_config_get_all() at
least for now. However, I may consider a change on this in the future to
limit the access to only the keys provisioned with WPS (the current
version seems to limit this anyway with get_keys=0, but it can be

Are there any other missing patches that I would have missed? Is there
any good way for me to test the new interface?

Jouni Malinen                                            PGP id EFC895FA

More information about the Hostap mailing list