[PATCH v2] Allow wpa_supplicant to use libnl-2.0.

Pavel Roskin proski
Mon Jul 6 11:58:58 PDT 2009


On Mon, 2009-07-06 at 09:50 -0500, Jon Loeliger wrote:
> @@ -46,14 +46,15 @@
>  #ifdef HOSTAPD
>  #include "ieee802_11_common.h"
>  
> +#endif /* HOSTAPD */

The empty line before #endif is not needed.

> -LIBS += -lnl
> +LIBS += -lnl -lnl-genl

That would break libnl 1.1!  Please see how hostapd/Makefile does it:

LIBS += -lnl
ifdef CONFIG_LIBNL20
LIBS += -lnl-genl
CFLAGS += -DCONFIG_LIBNL20
endif
endif

What adding support for something new, it's very important to test that
the existing functionality is not affected.

Apart from that, the patch is OK.

-- 
Regards,
Pavel Roskin



More information about the Hostap mailing list