[PATCH] WPS-UFD implementaion (proposal)

Jouni Malinen j
Tue Feb 24 13:00:29 PST 2009

On Mon, Feb 23, 2009 at 01:10:31PM +0900, Masashi Honma wrote:

> I ported it and have done same test. Please see attachment.

Thanks! This worked fine in my tests after some minor cleanup/fixes for
compiler warnings. I'm doing some cleanup in a separate branch first and
once this is done, will apply the changes into the 0.7.x branch.

The main area I need to fully understand is the change in Diffie-Hellman
key lifetime and whether there is re-use of the keys even for the
non-UFD case. Other than that, I think the code is ready to be included
in the main development branch. I made the UFD support build conditional
on CONFIG_WPS_UFD=y, i.e., this will not be built by default. This can
reduce the binary size if UFD support is not available in the device
anyway and some of the wps_ufd.c calls are not necessarily available in
all target operating systems, so it is safer to provide a build option
for this.

Jouni Malinen                                            PGP id EFC895FA

More information about the Hostap mailing list