[PATCH 2/2] wpa_gui-qt4: tweak icon Makefile

Jouni Malinen j
Sun Nov 16 12:15:01 PST 2008

On Wed, Nov 12, 2008 at 08:00:45AM +1000, Kel Modderman wrote:

> Please check to see if the SVG plugin was loaded, by looking for 'svg' in
> the supported image type list using below patch.

No sign of svg support on Windows.. Great.

> On a deeper look, the win32 deployment guide [1] states that extra plugins
> (such as for SVG) should be distributed with the application... I do not like
> the sound of this very much, and guess you may not either.

Hmm.. There seems to be a way of statically linking in plugins. However,
I have no idea how to make that work. I tried to link in qsvg plugin
statically and that did not add svg to the supported list. I would like
to an installer for the Win32 binary at some point anyway, so adding
some extra files would not be that bad.

> However, I really would like to avoid using any other image format such as png
> just for the sake of win32, perhaps the tray icon can be disabled for platforms
> which do not have the SVG loader available at runtime? Added that to the patch
> too for comment.

That's likely a useful addition anyway, but I would like to see if the
tray icon can be made to work with reasonable amount of work and not too
many extra dependencies for the installation. Then again, I would also
be fine of making a special Win32 build with PNG icon (once I figure out
how to do that ;-) and leave the default to use SVG.

Jouni Malinen                                            PGP id EFC895FA

More information about the Hostap mailing list