HostAP Digest, Vol 67, Issue 4

[Karl Rudnick]

I am having a problem with my hostap driver (Intersil Prism 2.5, 
firmware 1.4.9) on a Compaq Presario 2100, running ubuntu 8.10.
I mentioned this in an earlier post, Vol66, Issue 36. But to address 
your comment on an OB1 error, if I execute an iwconfig, I get something like

wlan0     IEEE 802.11b  ESSID:"ANYSIX
"  
          Mode:Managed  Frequency:2.412 GHz  Access Point: 00:21:29:63:78:1C   
          Bit Rate:2 Mb/s   
          Retry short limit:8   RTS thr:off   Fragment thr:off
          Power Management:off
          Link Quality=24/70  Signal level=-65 dBm  Noise level=-90 dBm
          Rx invalid nwid:0  Rx invalid crypt:1784  Rx invalid frag:0
          Tx excessive retries:0  Invalid misc:9   Missed beacon:0

Note that my ESSID is 6 chars, but iwconfig shows a 7th garbage char. I 
have no clue whether this is getting in the way of my connection - just 
an observation at this point. I have another laptop, runnuning ubuntu 
8.04 with the iwl3945 driver which works just fine and iwconfig shows 
exactly 6 characters as expected.

-Karl Rudnick


hostap-request at lists.shmoo.com wrote:
> S
> Message: 1
> Date: Sun, 2 Nov 2008 23:08:34 +0100
> From: "Jouke Witteveen" <j.witteveen at gmail.com>
> Subject: Off-by-one error in drivers?
> To: hostap at lists.shmoo.com
> Message-ID:
> 	<3993a4980811021408v3e3b8743m34ac9dec81d19d0d at mail.gmail.com>
> Content-Type: text/plain; charset=ISO-8859-1
>
> Hello all,
>
> If I am right the following wpa_supplicant drivers contain an OBOE
> concerning IFNAMSIZ:
> driver_atmel.c
> driver_broadcom.c
> driver_hostap.c
> driver_ipw.c
> driver_madwifi.c
> driver_ndiswrapper.c
> driver_nl80211.c
> driver_prism54.c
> driver_ralink.c
> driver_wext.c
> driver_wired.c
>
> They all have an ifname c-string of IFNAMSIZ + 1 bytes as to fit an
> interfacename of IFNAMSIZ characters. They then go on to use
> os_strlcpy to copy at most IFNAMSIZ characters from the ifname to some
> other variable. Not only does it look like the null character is not
> accounted for, it also seems to neglect that strlcpy _will_ write the
> terminating character. Because of this last caveat an interfacename of
> IFNAMSIZ characters gets truncated (the last character is turned into
> '\0').
>
> Can anyone comment on this?
>
> Regards,
> Jouke Witteveen
>