[PATCH] Removed #define required for older driver

Pavel Roskin proski
Tue May 13 22:47:19 PDT 2008

On Tue, 2008-05-13 at 15:01 -0600, Michal Kozlowski wrote:
> Removed some #defines that where required about a year ago, but the
> main madwifi driver handles this case correctly.

What is "the main madwifi driver"?

> -#ifdef MADWIFI_NG
>  	if (iebuf[1] == 0 && ie.rsn_ie[1] > 0) {
> -		/* madwifi-ng svn #1453 added rsn_ie. Use it, if wpa_ie was not
> -		 * set. This is needed for WPA2. */
>  		iebuf = ie.rsn_ie;
>  	}
> -#endif /* MADWIFI_NG */

Your patch should have no effect for any version of MadWifi released in
the last several years.  MADWIFI_NG is defined if
IEEE80211_IOCTL_SETWMMPARAMS is defined, and it has been defined for a
long time.

The patch would only affect madwifi-old-openhal (of anything are least
remotely recent), but even that is obsoleted by ath5k.  I'd rather see
all madwifi-old support removed from hostap and wpa_supplicant.

Pavel Roskin

More information about the Hostap mailing list