Manfid typographical error in hostap_cs.c for Dlink dwl-650p?

[re2823 at Safe-mail.net]

-------- Original Message --------
From: Pavel Roskin <proski at gnu.org>
To: re2823 at Safe-mail.net
Cc: hostap at shmoo.com
Subject: Re: Manfid typographical error in hostap_cs.c for Dlink dwl-650p?
Date: Fri, 29 Dec 2006 17:24:46 -0500

> Hello!
> 
> On Sun, 2006-12-24 at 04:26 +0000, re2823 at Safe-mail.net wrote:
> 
> > I cannot get my dwl-650p working on Debian Etch ("modprobe hostap_cs"
> > does not create an extra interface), and I think that this might be due
> > to a possible error in the manfid for my card. "pccardctl ident"
> > returns:
> > 
> > Socket 0:
> >   product info: "D-Link", "DWL-650 Wireless PC Card RevP", "ISL37101P-10", "A3"
> >   manfid: 0x000b, 0x7110
> >   function: 6 (network)
> > 
> > To find out if my card is supported in linux, I read the source code in
> > the linux-2.6.19.1 kernel that I download from www.kernel.org. The ids
> > in linux-2.6.19.1/drivers/net/wireless/hostap/hostap_plx.c start:
> > 
> >         { 0x000b, 0x7110 } /* D-Link DWL-650 Rev. P1 */,
> [skip]
> > while the ids in linux-2.6.19.1/drivers/net/wireless/hostap/hostap_cs.c
> > start:
> > 
> >         PCMCIA_DEVICE_MANF_CARD(0x000b, 0x7100),
> [skip]
> > Then I notice that these two lists are identical except for the first
> > entry, which is my card!
> 
> 0x000b:0x7100 is "SonicWALL Long Range Wireless Card", whereas
> 0x000b:0x7110 is D-Link DWL-650 Rev P.  Both should be supported.
> 
> I think 0x000b:0x7110 should be added to hostap_cs.c.  It is present in
> hostap_cs.conf distributed with hostap-0.4.9, but it was lost during
> conversion to the embedded PCMCIA IDs.  The ID is also present in
> wlan-ng.conf distributed with linux-wlan-ng, which further confirms that
> the card uses a compatible Prism chipset.
> 
> And while at that, I don't think D-Link DWL-650 Rev P would actually
> work in the PLX adapter (the card is 3.3V, the adapter is 5V), but it's
> a separate question.

I've added a bug report here:
http://hostap.epitest.fi/bugz/show_bug.cgi?id=197

Thank you to all for your help,

Jaime