[PATCH] [updated] encodeext vs. encode codepaths

Jouni Malinen jkmaline
Wed Feb 1 21:24:20 PST 2006

On Thu, Feb 02, 2006 at 12:07:58AM -0500, Dan Williams wrote:

> The proposed patch is attached.  I also corrected invalid usage of the
> IW_ENCODE_MODE mask in driver_wext.c from the original patch.  I had
> been using it as a flag, not a mask.

Thanks! I haven't yet had a chance to look at the details, but I'll try
to do that over the weekend. Just a quick note on one of the changes:
it is highly preferred that the driver wrapper API defined in driver.h
remains backwards compatible at source code level (i.e., does not
require changing driver_*.c files).

In other words, the change to set_auth_alg() handler is not desired. The
preferred way of adding new parameters for association is to add a new
field into struct wpa_driver_associate_params that will be passed
associate() handler. This allows adding new parameters without breaking
source level compatibility with driver wrapper implementations.

Jouni Malinen                                            PGP id EFC895FA

More information about the Hostap mailing list