[PATCH] dbus ctrl interface: fix reply message success argument

Dan Williams dcbw
Sat Dec 9 20:16:46 PST 2006

On Sat, 2006-12-09 at 15:53 -0800, Jouni Malinen wrote:
> On Mon, Dec 04, 2006 at 02:58:07PM -0500, Dan Williams wrote:
> > A mistype caused the success argument not to be added to the reply
> > message.
> Thanks for this and the other patches. I applied all four patches into
> the development branch (0.6.x). Should these be merged into 0.5.x for
> the stable release 0.5.7? Some of the patches were clear bug fixes, but

Yes, they should all go into 0.5.x too.  They are pretty much bug fixes,
or omissions in the DBus API that I noticed while hooking up the
NetworkManager bits to wpa_supplicant.  They don't break backwards
compatibility for the DBus API with any previous versions.

If you want to be _really_ strict, you can drop the "add interface
'state'" patch from 0.5.x, but without it you can't get the interface's
initial state (though a signal is sent when the state changes).  Again,
this does not break anything, but adds the additional method call.


> I'm not fully sure about all of them. The current policy on 0.5.x is
> that only bug fixes are accepted at this point.

More information about the Hostap mailing list