2.6.12-rc2-mm3: hostap: do not #include .c files

Jouni Malinen jkmaline
Mon Apr 18 19:12:38 PDT 2005

On Tue, Apr 19, 2005 at 04:03:12AM +0200, Adrian Bunk wrote:

> drivers/net/wireless/hostap/hostap.c:#include "hostap_crypt.c"

> Please do not #include .c files.

A tested patch would be appreciated.. ;-)

> A proper separation in a .c file and a header file is the better 
> solution.

Agreed and this is on my to-do list, but not very high on it. Some of
these would be relatively easy to fix, but the hardware specific ones
(different register offsets for PC Card/PLX/PCI) would require quite a
bit of changes to get rid of this.

Jouni Malinen                                            PGP id EFC895FA

More information about the Hostap mailing list