Question on Wireless Extensions design

[Jouni Malinen]

On Wed, Jan 28, 2004 at 11:14:27AM -0600, Lewis Adam-CAL022 wrote:

> It is a little vague to me why some of the iwpriv commands are handled via do_ioctl() and others are handled in the by separate iwpriv set/get routines in the driver.  For example, iwpriv commands such as monitor, wd_add and kickmac are all handled by the do_ioctl() handler in the driver, but other iwpriv commands such as get/set beacon interval are registered and handled in via their own routines (e.g. prism2_ioctl_priv_get_prism2_param() and prism2_ioctl_priv_prism2_param()).  What is the reason for this partitioning? 


This is mostly because of historical reasons.. All ioctl calls used to
be handled in the do_ioctl() handler. prism2_param was a collection of
"one integer" changes and it was eventually moved to the new private
wireless ioctl handler when support for sub-ioctls was added.

iwpriv monitor is deprecated and wds_add/del and add/del/kick mac use
MAC addresses, not single integers. maccmd could be moved to be
prism2_param sub-ioctl, but I haven't bothered since there has not been
need for freeing any private ioctl numbers.

-- 
Jouni Malinen                                            PGP id EFC895FA