[PATCH] Graceful handling of PDR 0x0413

[Jouni Malinen]

On Tue, Feb 03, 2004 at 04:47:36PM -0500, Pavel Roskin wrote:

> It's time to stop confusing users about modified firmware.  PDR 0x0413 in
> 1.8.x firmware points to the memory where the firmware is not downloaded.
> While we still don't know what it means, it should not be a fatal error in
> most cases.  Of all cards I know none has PDR 0x0413 in PDA, so the
> question how to plug it is useless.

Agreed. PDR 0x0413 may start to appear in new cards at some point in the
future, but we can deal with the issue then if people start reporting
problems with firmware downloads.

> The attached patch changes the behavior of prism2_srec so that PDRs
> pointing to the uncovered areas are only a fatal problem if we actually
> need to write something there.  If we are not plugging that PDR, it's not
> an error, just a warning.

Thanks, applied to both branches.

This does not look correct, though:

> +		if (!found && pos == 0) {
> +			printf("PDR 0x%04x not found from wlan "
> +			       "card PDA.  Not plugging.\n", p->pdr);
> +			return 0;
> +		}

"return 0" would terminate the for loop that was going through all SREC
plug records, so I replaced it with "continue".

-- 
Jouni Malinen                                            PGP id EFC895FA