[PATCH] Re: Hostap and fedora

[Rick Lim]

Hi Pavel,
That allowed me to get the driver compiled but when I did a make
install_pccard
I get.....

Installing hostap_crypt_*.o to /lib/modules/2.4.22-1.2174.nptlcustom/net
mkdir -p /lib/modules/2.4.22-1.2174.nptlcustom/net
cp -f driver/modules/hostap_crypt_*.o
/lib/modules/2.4.22-1.2174.nptlcustom/net
Installing hostap.o to /lib/modules/2.4.22-1.2174.nptlcustom/net
mkdir -p /lib/modules/2.4.22-1.2174.nptlcustom/net
cp -f driver/modules/hostap.o /lib/modules/2.4.22-1.2174.nptlcustom/net
Installing hostap_cs.o to /lib/modules/2.4.22-1.2174.nptlcustom/pcmcia
mkdir -p /lib/modules/2.4.22-1.2174.nptlcustom/pcmcia
cp -f driver/modules/hostap_cs.o
/lib/modules/2.4.22-1.2174.nptlcustom/pcmcia
/sbin/depmod -ae
depmod: *** Unresolved symbols in
/lib/modules/2.4.22-1.2174.nptlcustom/kernel/arch/i386/kernel/powernow-k7.o
depmod:         dmi_broken


Any ideas on how to fix this????
TIA



-----Original Message-----
From: Pavel Roskin [mailto:proski at gnu.org]
Sent: Friday, April 16, 2004 9:36 AM
To: Rick Lim
Cc: hostap at shmoo.com
Subject: [PATCH] Re: Hostap and fedora


On Fri, 16 Apr 2004, Rick Lim wrote:

> Hi there,
> I am using Fedora core 1 and trying to compile the Hostap driver 0.2.0 and
I
> keep getting this error
[snip]
> driver/modules/hostap_compat.h:73: redefinition of `free_netdev'
> /usr/src/linux-2.4/include/linux/netdevice.h:877: `free_netdev' previously
> defined here

It happens because Fedora uses 2.4.22 kernel with patches that add
free_netdev(), which appeared in 2.4.23 kernel.  This problem has been
reported in many other drivers.  The solution used by Orinoco driver is to
use a macro instead of an inline function.  Nobody has complained so far.

While inline functions are better for active development because they
check the arguments and thus find errors in the new code, the macros are
safer for backwards compatibility because they can be undefined and
redefined to prevent conflicts.

The attached patch should help you.  It should also be applied to CVS.

--
Regards,
Pavel Roskin