Deauthentication of inactive STA causes a error

[Jiri Fojtasek]

Jiri Fojtasek wrote:

> Jiri Fojtasek wrote:
>
>> Hello Jouni
>>
>> Iam trying to solve problem with random disassociatoin of my WDS 
>> clients (in cause of few minutes not responding from my WDS clients). 
>> I have done for this reason  a patch that that give me for this 
>> reason more detailed informations about the "Could not find STA for 
>> this TX error" error message ...
>>
>> I have found that the deauthentication frame always followed by this 
>> message:
>>
>> wlan0: STA 00:02:72:00:0f:f8 did not ACK activity poll frame
>> wlan0: sending disassociation info to STA 
>> xx:xx:xx:xx:xx:xx(last=2189385, jiffies=2219485)
>> wlan0: sending deauthentication info to STA 
>> xx:xx:xx:xx:xx:xx(last=2189385, jiffies=2219585)
>> wlan0: Could not find STA xx:xx:xx:xx:xx:xx for this TX error 
>> (jiffies=2219585)
>>
>> (xx:xx:xx:xx:xx:xx is mac of the STA being deauthenticated)
>>
>> I think it mean that deauth frame is not sent ...
>>
>> I have took a deep look for this problem, and have found that in the 
>> hostap_ap.c, exactly in the ap_handle_timer function is imediatly 
>> after sending the deauth frame is the sta dealocated by ap_free_sta, 
>> so i think the delivery od the deauth frame must fail ...
>>
>> I think the solution should be by calling  the "ap_free_sta" in next 
>> sheduled of the "ap_handle_timer" event .
>>
>> PS: I had the same problem before you fix the activity pooling ...
>>
>> Jiri
>>
>>
>> _______________________________________________
>> HostAP mailing list
>> HostAP at shmoo.com
>> http://lists.shmoo.com/mailman/listinfo/hostap
>>
> Next proof . Txexc event is called in next jiffies:
>
> wlan0: STA xx:xx:xx:xx:xx:xx did not ACK activity poll frame
> wlan0: sending disassociation info to STA 
> xx:xx:xx:xx:xx:xx(last=2360077, jiffies=2390177)
> wlan0: sending deauthentication info to STA 
> xx:xx:xx:xx:xx:xx(last=2360077, jiffies=2390277)
> wlan0: Could not find STA xx:xx:xx:xx:xx:xx for this TX error 
> (jiffies=2390278)
>
> Jiri
>
> _______________________________________________
> HostAP mailing list
> HostAP at shmoo.com
> http://lists.shmoo.com/mailman/listinfo/hostap
>
I forgot posr the patch whish show more deatils form tha error message:
--- ./hostap-0.0.3/driver/modules/hostap_ap.c   2003-06-25 
06:40:23.000000000 +0200
+++ ./hostap-0.0.3.work/driver/modules/hostap_ap.c      2003-06-26 
20:06:06.000000000 +0200
@@ -2908,10 +2908,9 @@
        /* FIX: is addr1 correct for all frame types? */
        sta = ap_get_sta(local->ap, txdesc->addr1);
        if (!sta) {
-               spin_unlock(&local->ap->sta_table_lock);
-               PDEBUG(DEBUG_AP, "%s: Could not find STA for this TX 
error\n",
-                      local->dev->name);
-               return;
+               PDEBUG(DEBUG_AP, "%s: Could not find STA " MACSTR " for 
this TX error (jiffies=%lu)\n",
+                      local->dev->name,MAC2STR(txdesc->addr1),jiffies);
+               goto done;
        }

        sta->tx_since_last_failure = 0;
@@ -2943,6 +2942,7 @@
                }
                sta->tx_consecutive_exc = 0;
        }
+ done:
        spin_unlock(&local->ap->sta_table_lock);
 }