prism2_rx (hostap_hw.c) patch

Jouni Malinen jkmaline
Wed Jul 9 10:57:10 PDT 2003


On Tue, Jun 17, 2003 at 11:47:12AM +0200, Lubomir Gelo wrote:

> Hostap 0.0.3 introduced bug in prism2_rx (hostap_hw.c) in calculating
> size for dev_alloc_skb. Driver hangs in monitor mode if frame of
> certain length is received. Verified with gcc-2.95 and gcc-3.3 and
> secondary FW 1.4.9 and 1.5.6. 

Thanks for reporting this. I haven't seen this happening in my tests
since my card did not seem to report triggering data_len values (STA f/w
1.5.6). However, I noticed that my card seemed to be delivering many
Acknowledgement frames with invalid data_len and previous version of the
driver was dropping these. Making this work better required a bit
different patch from yours, but it should also fix the special cases.
Please let me know if this version does not fix the hangs you have been
seeing.

I modified the RX path to accept such cases in monitor mode and handle
shorter than RX desc skb's properly. These seemed to improve monitor
mode operations at least for quick bursts of frames. Some Ack frames
might be received with bogus data and incorrect length, but at least
most Acks are now reported all the way to the sniffer program.

-- 
Jouni Malinen                                            PGP id EFC895FA




More information about the Hostap mailing list