No more space in this STA's PS mo

[Jouni Malinen]

On Sat, Dec 07, 2002 at 09:25:59PM -0500, Doug Yeager wrote:

> the dmesg log that i listed was from the AP, i assumed the word "this 
> sta's" meant the AP but i could have interpreted incorrectly.  is that what 
> you are saying?  those messages seem to build, even with no clients in the 
> area.

Yes, that message is misleading.. It does indeed mean a client station,
not the "AP station". I added client hwaddr to it so that it will be
easier to understand and debug. In addition, I added TIM bit setting
here to make sure that it is set even if AP's wlan card get reseted. You
can do the following changes manually or just use the latest CVS version
to get the new version.

Please also note, that these messages might be about a station that was
using power saving and that left the AP during some network activity. AP
would be adding all incoming frames to PS buffer in this kind of case
and since the station is not anymore present there will be no PS poll
frames to empty the queue.


diff -u -p -r1.33 hostap_ap.c
--- driver/modules/hostap_ap.c  26 Nov 2002 04:59:16 -0000      1.33
+++ driver/modules/hostap_ap.c  8 Dec 2002 02:47:35 -0000
@@ -2620,8 +2620,12 @@ ap_tx_ret hostap_handle_sta_tx(local_inf
        }
 
        if (skb_queue_len(&sta->tx_buf) >= STA_MAX_TX_BUFFER) {
-               PDEBUG(DEBUG_PS, "No more space in this STA's PS mode "
-                      "buffer\n");
+               PDEBUG(DEBUG_PS, "%s: No more space in STA (" MACSTR ")'s PS "
+                      "mode buffer\n", local->dev->name, MAC2STR(sta->addr));
+               /* Make sure that TIM is set for the station (it might not be
+                * after AP wlan hw reset). */
+               hostap_set_tim(local, sta->aid, 1);
+               sta->flags |= WLAN_STA_TIM;
                ret = AP_TX_DROP;
                goto out;
        }


-- 
Jouni Malinen                                            PGP id EFC895FA