aactomp3 - substitute code - for deprecated option

[Vangelis forthnet]

On Sun Sep 4 16:19:14 BST 2016, Shevek wrote:

> On 4 Sept 2016 at 13:42, Kevin Lynch wrote:
> > (snip)
>> after the file download is complete
>> takes the aac file, converts to mp3 and

Not quite - when the --aactomp3 (--mp3) switch
has been activated, GiP actually downloads audio
in --raw mode; the completed .ts (haf/hlsaac radiomodes)
or .flv (flashaac radiomode) file is then transcoded to a
tagless .mp3 file (using libmp3lame encoder inside ffmpeg)
in a one-step process and then the .mp3 file is finally
fully tagged (including thumbnail) via the MP3::Tag
perl module (included in the Strawberry Perl mini
package installed by the Windows installer - on other
OSes, maybe you have to install MP3::Tag manually
via CPAN or similar, see
https://github.com/get-iplayer/get_iplayer/wiki/installation#perl

> Additional Perl modules are used for optional functionality :
> MP3::Tag [DEPRECATED] - Full ID3 tagging of MP3 files ...).

>> then calls atomic_parsley to populate the metadata.

AtomicParsley is an MPEG-4 container tagger,
so it's used exclusively for MP4 (TV) and M4A (radio)
files; it can't tag audio MP3 files...

> AIUI the metadata has already been applied,
> aactomp3 merely converts to mp3 and the metadata
> is copied as part of the conversion

Not so, please read above comment; although
what you said pretty much describes accurately
what happens with the new route the dev wants us to take;

--command="ffmpeg -i \""<filename>"\" -vn -c:a libmp3lame -b:a 
320k -id3v2_version 3 -write_id3v1 1 -y \""<dir>/<fileprefix>.mp3"\""

Tagged (by AP) M4A file is transcoded to MP3
and FFmpeg carries over as much of the MP4 tag
as can be converted to ID3 (MP3) tag; victim of this
approach is the MP4 thumbnail, which is not carried
over (due to -vn switch)

Best regards,
Vangelis.