Another download issue.

[Vangelis forthnet]

On Thu Oct 9 22:47:59 BST 2014, dinkypumpkin wrote:

> Patch has been pushed to GitHub.

 Many thanks for your code and the speedy response to
the latest changes (thumbs up).

> I doubt this is complete yet, but it works for the examples
> of >7-day downloads that have been posted to date.

Video test: pid=b04kn3vp ("Click - 27/09/2014")

get_iplayer -i --pid=b04kn3vp --modes=flashvhigh --force

The command prompt window stalls for 25-30s after the line:
"INFO: pid not found in tv cache"
but eventually the download starts and completes:

INFO: Recorded D:\Vangelis\iPlayer 
Recordings\Click_-_27_09_2014_b04kn3vp_defaul
t.mp4

INFO: Downloaded Thumbnail to 'D:\Vangelis\iPlayer 
Recordings\Click_-_27_09_2014
_b04kn3vp_default.jpg'
INFO: MP4 tagging MP4 file

 Started writing to temp file.
 Progress: =============================================>100%|
 Finished writing to temp file.

Radio test: pid=b04k6rgy ("The Chris Evans Breakfast Show - 01/10/2014")

get_iplayer --type=radio -i --pid=b04k6rgy --modes=flashaac --force --tag-podcast-radio

Programme is in the radio cache (?), so the download starts quite soon;

INFO: Recorded D:\Vangelis\iPlayer 
Recordings\The_Chris_Evans_Breakfast_Show_-_T
ip-Top_Tiffin_b04k6rgy_default.m4a

ERROR: Thumbnail Download failed
INFO: MP4 tagging M4A file

 Started writing to temp file.
 Progress: =============================================>100%|
 Finished writing to temp file.

But as you are able to see for yourself, THUMBNAIL DOWNLOAD FAILS
and hence AtomicParsley produces an M4A file without an embedded "cover".
This is, of course, no big deal, but since for video files thumbnails are 
downloaded,
it'd be nice to "fine-tune"  the code a bit more so that the same happens 
for audio, too.

Many thanks for your devotion to GiP,
Vangelis.