Your message to get_iplayer awaits moderator approval

[dinkypumpkin]

On 08/11/2014 21:08, C E Macfarlane wrote:
> 1)	This patches get_iplayer v2.90 to use nice with the parameter -n 19,

Others have beaten me to the punch here: nice does not belong in 
get_iplayer. Use a wrapper script or shell alias to apply nice to 
get_iplayer itself.  Leaving that aside, I still couldn't accept this 
patch.  Making a feature like this both configurable and optional isn't 
a "desirable improvement" - it is required.  Otherwise, the principal 
effect of your code would be to break get_iplayer for all Windows users 
- not an option.  More problematic is the fact that virtually all of 
your code is unnecessary.  If you want to continue using nice in your 
version of get_iplayer, let me suggest you simply prepend nice onto the 
external command in run_cmd().  There is no need to touch any command 
definitions or change all the binary checks.  And as a matter of form, 
it is not necessary to date and initial your changes.  The version 
control system keeps track of who did what.

> 2)	This patches get_iplayer v2.90 to use ffmpeg rather than mplayer to
> convert *.flv to *.mp3:

This has come up several times before.  Most versions of ffmpeg/avconv 
in the wild require suppression of all error messages in order to avoid 
those messages generated during remux to MP3.  In principle, that never 
seems like a good idea.  But, now that WMA streams are going away soon 
there is no other use for mplayer in get_iplayer (yes, I know ffmpeg 
could pull WMA streams, but it's not worth the bother at this point). 
So, sometime in the next 2-3 months I'll switch over to ffmpeg for 
re-muxing MP3 when I get rid of other mplayer-dependent parts of the code.

> 3)	This patches ffmpeg v2.4.2 (possibly other versions) to avoid said
> conversion above producing myriads of redundant warning messages:

It's not necessary to hack ffmpeg.  Just use -loglevel