[PATCH] Fix warning with older versions of Perl

dinkypumpkin dinkypumpkin at gmail.com
Tue Oct 1 07:38:52 EDT 2013


On 01/10/2013 06:34, Bastien Nocera wrote:
> INT=

Thanks.  That all looks as it should, and I would have been surprised if 
it were otherwise.  But, I've no idea why get_iplayer finds that 
$SIG{INT} has already been set to "IGNORE".  get_iplayer doesn't do so 
itself.  What are you doing in get_iplayer when the error appears?

I also don't understand your patch:

> -	$SIGORIG{$signal}->() if $SIGORIG{$signal};
> +	$SIGORIG{\@$signal}->() if $SIGORIG{\@$signal};

Making $signal an array reference and using it as in index into %SIGORIG 
just means that the if test will always fail.  That probably doesn't 
make any difference in this context, but it doesn't seem like the right 
answer to me.  Try this instead and let me know if it works for you:

$SIGORIG{$signal}->() if ref($SIGORIG{$signal}) eq 'CODE';




More information about the get_iplayer mailing list