web-settings-and-get_iplayer-defaults-harmonisation

[Pete Beardmore]

Quoting Pete Beardmore <pete.beardmore at msn.com>:

> Quoting Pete Beardmore <pete.beardmore at msn.com>:
>
>> #patch attached (hopefully!)
>>
>> hi,
>>
>> as a new user a few months ago i was a little frustrated as i  
>> couldn't work out where settings that were used came from.  
>> specifically with 'modes', as i wanted HD and it didn't work out of  
>> the box.
>>
>> having tried combinations of 'flashhd,flashhd1,flashhd2' in option  
>> files and in the webserver to no avail, i settled on 'best' (having  
>> finally resorted to reading instructions!). this was set in my  
>> options files under /srv/www/iplayer/.get_iplayer but still, via  
>> the web server (be it my apache or the included standalone), i  
>> could not get the underlying flvstreamer/rtmpdump processes to  
>> behave and show me that attempts at flashhd1 etc. quality streams  
>> were being made.
>>
>> so mistake #1. although the instruction state that one should  
>> ensure HOME is set correctly, don't assume that that is for reading  
>> any options files which you might have created there  
>> (/srv/www/iplayer/get_iplayer/options) whilst trying out the  
>> 'get_iplayer' script. the web server doesn't read them!
>>
>> mistake #2. ALWAYS use the --prefs-add fuctionality to add options  
>> to the options file to ensure you get the right format! for  
>> example, the entry..
>>
>> modes 'best,flashhd,flashhd1,flashhd2,flashvhigh'
>>
>> ..f@&Sed me over as i'd add quotes!
>>
>> anyway. finally i got up and running and so on to the hackery. the  
>> attached patch makes the web server work as i want it to with  
>> regard to where defaults come from. specifically it:
>>
>> 1. only persists web setting as cookies when none default
>> 2. adds ability to return settings back to defaults
>> 3. bases defaults on get_iplayer option files
>> 4. harmonises defaults structure through single opt_defaults array
>>
>> use cases:
>>
>> 1. 20+ empty defaults is bad, particularly when i have to scroll  
>> through them all to find non get_iplayer related cookies on my  
>> (apache) server
>> 2. i wanted to delete all get_iplayer related cookies and go back  
>> to the default set of columns
>> 3. i've made the effort to add 'excludecategory' / 'excludechannel'  
>> options in my options file, i don't want to change those is  
>> multiple places. and if i've set something as important as 'modes'  
>> for use with 'get_iplayer' then i really want that same setting  
>> used in the web front end
>> 4. specifically modes (originally default_modes) and cols  
>> (originally default_headings) which didn't even feature in the  
>> original option structure->default mechanism.
>>
>> hope this is seen as an improvement, in spite of the rather  
>> clueless way i happened on requiring the changes :)
>>
>> cheers
>
> hi all,
>
> apologies to anyone reading the above a second time. the original  
> mail dated Jan 30 made it to the list, but after no feedback in  
> several week a second look has made me realise that i'd broken list  
> rules on html content. try again! if dinkypumpkin or anyone equally  
> as active on the list could formally reject my offerings (if they  
> aren't wanted), then i'd appreciate it so i can move on
>
> since sending the initial patch, i've made a slight change to the  
> button names as i wanted to make a better distinction between the  
> 'persistence' settings mechanisms, and re-iterate that defaults come  
> from files! i now have 'Apply Changes', 'Update Cookies', and 'Reset  
> to Defaults'. a second patch is also appended to this modified  
> patch, and this fixes the issue whereby checkboxes for selected  
> programmes are disabled following an attempted record, instead of  
> merely unselected
>
> cheers,
> Pete.

hi Jon and dinkypumpkin,

apologies for the noise, i'd clearly missed your responses - thank you  
for those. it will take me a while to process all of dinkypumpkin's  
excellent input while revisiting the work. i'd never looked at perl  
before those two days so i'm not surprised that there are mistakes.

i'll come back as soon as i can