Replace libfaac with aac in get_iplayer.cgi?

[bat guano]

----------------------------------------

> > In the latest ffmpeg, libfaac is no longer supported. Should references
> > to it be replaced with the experimental aac, which is?
>
Hi
I didn't realize that get_iplayer converted anything into aac.
Just de-muxed and re-muxed.

I've found the relevant section in file get_iplayer.cgi.

What is this used for?
Or is it redundant code?


*************************************************************************************
sub build_ffmpeg_args {
        my ( $filename, $mimetype, $ext, $abitrate, $vsize, $vfr ) = ( @_ );
        my @cmd_aopts;
        if ( $abitrate =~ m{^\d+$} ) {
            # if this is flv stream output then use the AAC codec
            if ( lc( $ext ) =~ m{^(flv|aac|m4a)$} ) {
                # Tweak: ffmpeg cannot understand aac or m4a as audio output formats - force flash audio
                $ext = 'flv' if lc( $ext ) =~ m{^(aac|m4a)$} && $mimetype =~ m{^audio};
                push @cmd_aopts, ( '-acodec', 'libfaac', '-ab', "${abitrate}k" );
            # else just copy  the codec?
            } else {
                push @cmd_aopts, ( '-ab', "${abitrate}k" );
            }
        } else {
            if ( lc( $ext ) eq 'flv' ) {
                # 160k is the max for libfaac!
                push @cmd_aopts, ( '-acodec', 'libfaac', '-ab', '160k' );
            }
            # cannot copy code if for example we have an aac stream output as WAV (e.g. squeezebox liveradio flashaac)
            #push @cmd_aopts, ( '-acodec', 'copy' );
*************************************************************************************