[PATCH] Revamped --showoptions and search options initialisation

dinkypumpkin dinkypumpkin at gmail.com
Wed May 18 09:02:55 EDT 2011


This change has been incorporated into my get_iplayer fork.  Instructions here:

https://github.com/dinkypumpkin/get_iplayer/wiki/instructions

Commit message follows, patch is attached.

The init_search() subroutine has been changed:
1. An unnecessary search will no longer be performed when
--showoptions is used
2. All options processing occurs at head of init_search() so that
--showoptions may be invoked in a short-circuit fashion.
3. Validation error will be shown along with options listing
when --showoptions used
4. --{metadata,subs,thumb}only will force --nowrite, though it may
still be specified on the command line.  Programme may still be
streamed with --player, --nowrite, and --stdout when --get is used.

The effect of these changes is that --showoptions can be added
to any command line as means to check options before search
execution or in event of an error.
---
 get_iplayer |  147 ++++++++++++++++++++++++++++++++--------------------------
 1 files changed, 81 insertions(+), 66 deletions(-)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0012-Revamped-showoptions-and-search-options-initialisati.patch
Type: text/x-patch
Size: 5600 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/get_iplayer/attachments/20110518/ca02d280/attachment.bin>


More information about the get_iplayer mailing list