[PATCH] Re: atomicparsley tagging issue

[Jimmy Aitken]

There is a version of AtomicParsley which tags the 'longDescription'
field.  I have a modified version of AtomicParsley which allows this
and have a small patch which allows this tag to be added if the
version supports it.  Here's the patch to allow it.  Line numbers may
vary due to the other patches I've added recently.

--- get_iplayer.orig	2011-04-02 08:59:43.000000000 +0100
+++ get_iplayer	2011-04-02 08:59:11.000000000 +0100
@@ -4384,6 +4384,12 @@
 				push @cmd, "--album", $prog->{name};
 			}

+			# Check to see if AtomicParsley has been modified to allow full description
+			my $atomic_log = `$bin->{atomicparsley} /dev/null --longDescription 2>&1`;
+			if ( $atomic_log =~ /requires an argument/ ) {
+				push @cmd, '--longDescription', $tags->{desc};
+			}
+
 			# Add the thumbnail if one was downloaded
 			push @cmd, "--artwork", $prog->{thumbfile} if -f $prog->{thumbfile};


On Fri, Apr 1, 2011 at 11:48 PM, dinkypumpkin <dinkypumpkin at gmail.com> wrote:
>
> On 1 Apr 2011, at 23:04, Jon Davies wrote:
>
>> On 9 February 2011 22:55,  <grz88 at wolke7.net> wrote:
>>> However, I wonder why does get_iplayer use the short description (descshort) field, rather that the long description (desc) for both the "description" and "comment" tag. Wouldn't it make more sense to tag the file using the full programme description? Maybe there is good reason why things are the way they are. If not, then I suggest changing the invocation of atomicparsley to use the "desc" field for the "description" tag (and keep shortdesc for the comment). Below is a patch that does this.
>
> At least in iTunes, the "description" and "comment" fields are both limited to 255 chars, so the full "desc" value (which can be quite long for some programmes) will be truncated.  I guess it boils down to whether truncation matters and whether iTunes should be the yardstick, though I don't think it's unique in this respect.  Alternatively, the full "desc" value can be shoved into the "lyrics" field used by iTunes and other apps.  I've worked out the full mapping from get_iplayer fields to all iTunes fields for both ID3 and MP4, which I use in a command script launched by get_iplayer to automatically tag files and put them in iTunes.  I'll work out the equivalent id3v2 and atomicparsley command lines and perhaps start a new thread on this issue.  I think the tagging in get_iplayer could be extended a bit, and it would be useful to get feedback from people using other media managers and maybe put together a more comprehensive tagging patch.
>
>
> _______________________________________________
> get_iplayer mailing list
> get_iplayer at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/get_iplayer
>