[PATCH] Re: atomicparsley tagging issue

Jon Davies jon at hedgerows.org.uk
Fri Apr 1 18:04:17 EDT 2011


Since it's looking like someone's going to patch the source for
get_iplayer soon, can I vote for this patch to go in as well?

and I know I can't really vote for my own patch, but there's another one here:
  http://lists.infradead.org/pipermail/get_iplayer/2011-February/000803.html
which fixes a bug with creating folders

Cheers
Jon

On 9 February 2011 22:55,  <grz88 at wolke7.net> wrote:
> I use atomicparsley to have my downloads tagged, which works great.
>
> However, I wonder why does get_iplayer use the short description (descshort) field, rather that the long description (desc) for both the "description" and "comment" tag. Wouldn't it make more sense to tag the file using the full programme description? Maybe there is good reason why things are the way they are. If not, then I suggest changing the invocation of atomicparsley to use the "desc" field for the "description" tag (and keep shortdesc for the comment). Below is a patch that does this.
>
> Cheers,
> Robin
>
--- a/get_iplayer       2011-02-04 21:09:33.000000000 +0100
+++ b/get_iplayer       2011-02-09 18:10:00.000000000 +0100
@@ -4321,7 +4321,7 @@
                       my @cmd = (
                               $bin->{atomicparsley}, $prog->{filename},
                               '--TVNetwork',  $tags->{channel},
-                               '--description',$tags->{descshort},
+                               '--description',$tags->{desc},
                               '--comment',    $tags->{descshort},
                               '--title',      $title,
                               '--TVShowName', $tags->{longname},



More information about the get_iplayer mailing list