[PATCH] Output AAC as M4A with metadata tags

[Jimmy Aitken]

String comparisons should use 'eq' and not '=='

Jimmy

On 1 Apr 2011, at 08:48, Shevek wrote:

> On 1 April 2011 08:44, Andy Waddington <andrew at pennine.demon.co.uk> wrote:
>> Sometime before sending, Shevek typed (and on Friday 2011-04-01 sent):
>> 
>>> but this line is changing it to m4a:
>>> 
>>> $prog->{ext} = 'm4a' if $prog->{ext} = 'aac';
>>> 
>>> why?
>> 
>> I don't do perl, but with most languages, a test should be "=="
>> rather than "=". Is that the case here ? In which case the test
>> will be changeing the ext to "aac", returning true, and the main
>> command will then change it to "m4a".
>> 
>> Apologies if I'm barking up the wrong tree (there's a limit to
>> how many different languages one can learn at one time without
>> getting horribly confused :-)
>> 
> 
> Yep, that's what I thought too (I am a VB programmer moving to C# so
> it wasn't immediately obvious to me)
> 
> Perl does use == too but that doesn't fix it either (as per my follow-up post)
> 
> _______________________________________________
> get_iplayer mailing list
> get_iplayer at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/get_iplayer

Jimmy Aitken
jimmy.aitken at gmail.com
ph: 0794 105 4141