<div class="gmail_quote">On Fri, Mar 30, 2012 at 10:04 PM, Anand Gadiyar <span dir="ltr"><<a href="mailto:gadiyar@gmail.com">gadiyar@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Hi all,<br><br>I've just started playing with barebox on OMAP4. I see that with "Release v2011.11.0", my Panda could access the SD card contents, but with the current release it can no longer do so.<br><br>
Git bisect shows commit 82db23d3f4c1de25bbd4b222a3bd9e81d00414f8 (Use generic block layer to access the drives and do partition parsing) is when it stopped working.<br>
<br>Any pointers?<br><br>Thanks in advance,<br><font color="#888888">Anand<br><br>
</font></blockquote></div><br>Found the problem. I was using a 4GB SD card with just a single FAT32 partition. The pentry.size is reported as 7744449 which fails the check_offset_value() call.<br>I think this is the same issue Sanjeev reported in February.<br>
<br>Below patch seems to fix the issue for now. But I'm not sure what's the correct way to fix this.<br><br>Index: barebox/common/partitions.c<br>===================================================================<br>
--- barebox.orig/common/partitions.c<br>+++ barebox/common/partitions.c<br>@@ -129,8 +129,6 @@ static void __maybe_unused try_dos_parti<br> /* do we have to ignore this partition due to limitations? */<br>
if (check_offset_value(pentry.first_sec) != 0)<br>
continue;<br>- if (check_offset_value(pentry.size) != 0)<br>- continue;<br><br> if (pentry.first_sec != 0) {<br> pd->parts[pd->used_entries].first_sec = pentry.first_sec;<br>
<br>