<br><br><div class="gmail_quote">2011/4/11 Jean-Christophe PLAGNIOL-VILLARD <span dir="ltr"><<a href="mailto:plagnioj@jcrosoft.com">plagnioj@jcrosoft.com</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="im">On 20:21 Sun 10 Apr , Franck JULLIEN wrote:<br>
> 2011/4/10 Jean-Christophe PLAGNIOL-VILLARD <<a href="mailto:plagnioj@jcrosoft.com">plagnioj@jcrosoft.com</a>><br>
><br>
> > > index 0000000..2687377<br>
> > > --- /dev/null<br>
> > > +<br>
> > > +static int tse_get_ethaddr(struct eth_device *edev, unsigned<br>
> char *m)<br>
> > > +{<br>
> > > + /* There is no eeprom */<br>
> > so return the content of the register no?<br>
> ><br>
> > Well, the register is reseted to 0 when the MAC starts so there is<br>
> no<br>
> > Ethernet address<br>
> > to get.<br>
> ><br>
> except this function is supposed to return the mac address of the device<br>
> at<br>
> any time so after a set of it it will not be true any more<br>
><br>
> If I implement the function I get a "eth@eth0: got MAC address from<br>
> EEPROM: 00:00:00:00:00:00" at startup.<br>
> That why I returned -1 as what I could find int at91_ether.c......<br>
> Or, I could find something to return -1 as long as the MAC address hasn't<br>
> been set.<br>
><br>
</div>I known this issue I re-write recently the at91_ether and the same on macb<br>
will post the patch soon<br>
<br>
It's fine the uperlayer will see that it's not a valid mac so this will<br>
generate a random one<br>
cf net/net.c IIRC<br>
<br></blockquote><div><br></div><div>For me, it's a bit annoying to get this message at startup.</div><div><br></div><div>Don't you really think I could have a flag in the private structure to check</div><div>if an address has been set and then return -1 or the address in the </div>
<div>tse_get_ethaddr function ?</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
Best Regads,<br>
<font color="#888888">J.<br>
</font></blockquote></div><br>