<br><br><div class="gmail_quote">---------- Forwarded message ----------<br>From: <b class="gmail_sendername">Franck JULLIEN</b> <span dir="ltr"><<a href="mailto:franck.jullien@gmail.com">franck.jullien@gmail.com</a>></span><br>
Date: 2011/3/4<br>Subject: Re: [PATCH 00/54] New arch (NIOS2)<br>To: Sascha Hauer <<a href="mailto:s.hauer@pengutronix.de">s.hauer@pengutronix.de</a>><br><br><br><div>2011/3/4 Sascha Hauer <span dir="ltr"><<a href="mailto:s.hauer@pengutronix.de" target="_blank">s.hauer@pengutronix.de</a>></span></div>
<div><div class="gmail_quote"><div class="im"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi Franck,<br>
<div><br>
On Thu, Mar 03, 2011 at 11:58:14PM +0100, <a href="mailto:franck.jullien@gmail.com" target="_blank">franck.jullien@gmail.com</a> wrote:<br>
> From: Franck JULLIEN <<a href="mailto:franck.jullien@gmail.com" target="_blank">franck.jullien@gmail.com</a>><br>
><br>
> This is the base files of the Nios2 port. Almost everything is comming from u-boot.<br>
> When those files are acked, I'll post drivers and utility commands.<br>
<br>
</div>Soo many patches ;). You can safely combine all these into two<br>
patches, one for the nios2 support and one for the generic board.<br>
The patches are only useful as a whole anyway, so no need to split<br>
them up that fine. You will hit the list limit, so give me some time<br>
to go to the moderator interface and and it through.<br>
<br>
I'm not through all patches, but some remarks here:<br>
<br>
There is some whitespace damage all around like spaces which should be<br>
tabs.</blockquote><div><br></div></div><div>Is that a "Linux rule" ? Is there other ones ? (I always convert tabs to whitespaces....).</div><div class="im"><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Also, please do not use direct pointer derefs to access registers.<br>
You should use readl/writel accessors for them.<br>
<br></blockquote><div><br></div></div><div>Okay I will.</div><div class="im"><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Thanks for doing this work. Although I don't have a nios baord, I really<br>
appreciate extending barebox to more architectures.<br></blockquote><div><br></div></div><div>Barebox is so much better than Uboot, you guys did a really good job. Barebox</div><div>even helped my to understand some Linux concepts. </div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Sascha<br>
<font color="#888888"><br></font></blockquote><div><br></div><div>Hi Sasha,<div><br></div><div>I didn't how to split the patches so I splitted everything :) I'll fight with git to revert my commits and do it again...</div>
<div><br></div><div>This port is working but it's going to be a long process including it in barebox git because I don't have a lot of time</div><div>(my baby boy needs my time) and I'm not a git master at all, I'm just an hardware guy playing with the kernel (why the </div>
<div>hell it is so complicated ? I think it is kind of a filter/test for patchers. If you can't use git you can't send patches ;)).</div><div><br></div><div>Souldn't be less complicated if I had a separate branch to work on it ?</div>
</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><font color="#888888">
--<div class="im"><br>
Pengutronix e.K. | |<br>
Industrial Linux Solutions | <a href="http://www.pengutronix.de/" target="_blank">http://www.pengutronix.de/</a> |<br>
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |<br>
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |<br>
</div></font></blockquote></div><br></div>
</div><br>