<br><br><div class="gmail_quote">2011/1/3 Sascha Hauer <span dir="ltr"><<a href="mailto:s.hauer@pengutronix.de">s.hauer@pengutronix.de</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="im">On Mon, Jan 03, 2011 at 01:45:18PM +0100, Franck JULLIEN wrote:<br>
> 2011/1/3 Sascha Hauer <<a href="mailto:s.hauer@pengutronix.de">s.hauer@pengutronix.de</a>><br>
><br>
><br>
</div><div class="im">> I know CONFIG_BOARDINFO is board specific. However, I think it is more<br>
> conveniant<br>
> to have the possibility to define a banner text outside the Kconfig. For<br>
> example, I use<br>
> this in my config.h:<br>
><br>
> #define CONFIG_BOARD_BANNER_TEXT "\e[1;32m\<br>
> ***********************************************************************\n\<br>
> * Communication board bootloader (ODSFT0152) *\n\<br>
> ************************************************************************\<br>
> \e[0m\n\n"<br>
><br>
> So may be we could define this kind of banner in the Kconfig.....<br>
<br>
</div>Ok, I can see your problem. I think we should rather define a board<br>
specific function to display a banner than a string, so something like:<br>
<br>
config BOARD_BANNER<br>
bool<br>
<br>
#ifdef CONFIG_BOARD_BANNER<br>
display_board_banner();<br>
#else<br>
<div class="im"> printf(RELOC("Board: " CONFIG_BOARDINFO "\n"));<br>
</div>#endif<br>
<br>
This way we can also show runtime dependent information in the banner<br>
(like baseboard or whatever).<br></blockquote><div><br></div><div><span class="Apple-style-span" style="border-collapse: collapse; font-family: arial, sans-serif; font-size: 13px; "><div>Sounds great, I'll do this. Is there anyone responsible for the list in first place ?</div>
<div>Because if I do this in one way but someone would prefer do it another way and</div><div>finally the git boss wants it a third way.......</div><div><br></div><div>I'll try to post the new patch in response to this thread</div>
<div>using the right git command...By the way, I there anything more user friendly</div><div>than the git command line to send email in the right format ?</div><div><br></div><div>I told you this is a practice/test patch so I have a lot of questions/comments !</div>
</span></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="im"><br>
><br>
> Let me know if you don't like this. This patch was kind of a test for me and<br>
> we could<br>
> forget about it.<br>
><br>
> Although this patch was very small, we had a lot of discussion around it and<br>
> I don't want to imagine what it is going to be when I submit the nios2 port :)<br>
<br>
</div>Don't worry, the amount of comments you receive usually is not<br>
proportional to the patch size you send ;)<br>
<div><div></div><div class="h5"><br>
Sascha<br></div></div></blockquote><div><br></div><div><span class="Apple-style-span" style="border-collapse: collapse; font-family: arial, sans-serif; font-size: 13px; ">Ok, because I was worry :)</span></div><div> </div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><div><div class="h5">
<br>
--<br>
Pengutronix e.K. | |<br>
Industrial Linux Solutions | <a href="http://www.pengutronix.de/" target="_blank">http://www.pengutronix.de/</a> |<br>
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |<br>
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |<br></div></div></blockquote><div><br></div><div>Best regards,</div><div>FJ. </div></div><br>