[PATCH v4 6/6] drivers: usb: add usb_add_device to add a device

Fabian Pflug f.pflug at pengutronix.de
Fri Sep 4 06:58:30 PDT 2026


Before this pull request, the only one to create new USB devices was the
USB subsystem itselg, which did it in the usb_new_device function.
This function is not viable for the efi driver, as it cannot set the USB
descriptor as used by it.

Create a new header function to add a new USB device to the list of
known USB devices.

Modify the usb_new_device function to use the newly created header
instead of doing it itself and add it to efi-io-protocol for usb
devices.
---
 drivers/usb/core/usb.c             | 12 ++++++++++--
 drivers/usb/core/usb.h             |  1 +
 drivers/usb/host/efi-io-protocol.c |  2 ++
 3 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/core/usb.c b/drivers/usb/core/usb.c
index ce10b71f40..38b0ec2595 100644
--- a/drivers/usb/core/usb.c
+++ b/drivers/usb/core/usb.c
@@ -557,8 +557,7 @@ int usb_new_device(struct usb_device *dev)
 			dev->descriptor->idVendor, "%04x");
 	dev_add_param_uint32_fixed(&dev->dev, "idProduct",
 			dev->descriptor->idProduct, "%04x");
-	list_add_tail(&dev->list, &usb_device_list);
-	dev_count++;
+	usb_add_device(dev);
 
 	err = 0;
 
@@ -575,6 +574,15 @@ void usb_free_device(struct usb_device *usbdev)
 	free(usbdev);
 }
 
+void usb_add_device(struct usb_device *usbdev)
+{
+	if (!usbdev)
+		return;
+
+	list_add_tail(&usbdev->list, &usb_device_list);
+	dev_count++;
+}
+
 void usb_remove_device(struct usb_device *usbdev)
 {
 	int i;
diff --git a/drivers/usb/core/usb.h b/drivers/usb/core/usb.h
index b503e5b4a8..49a6938246 100644
--- a/drivers/usb/core/usb.h
+++ b/drivers/usb/core/usb.h
@@ -5,6 +5,7 @@
 struct usb_device *usb_alloc_new_device(void);
 void usb_free_device(struct usb_device *dev);
 int usb_new_device(struct usb_device *dev);
+void usb_add_device(struct usb_device *dev);
 void usb_remove_device(struct usb_device *dev);
 void usb_set_maxpacket_ep(struct usb_device *dev,
 			  struct usb_endpoint_descriptor *ep);
diff --git a/drivers/usb/host/efi-io-protocol.c b/drivers/usb/host/efi-io-protocol.c
index 4858d30eb9..5bc25d132f 100644
--- a/drivers/usb/host/efi-io-protocol.c
+++ b/drivers/usb/host/efi-io-protocol.c
@@ -273,6 +273,8 @@ static int create_usb_device(struct efi_usb_io_priv *priv)
 	/* register as root device for host */
 	host->root_dev = dev;
 
+	usb_add_device(dev);
+
 	return 0;
 
 out_err:

-- 
2.47.3




More information about the barebox mailing list