[PATCH 1/2] fs: pstore: don't claim uImages

Ahmad Fatoum a.fatoum at pengutronix.de
Tue Nov 3 06:32:29 PST 2026


From: Ahmad Fatoum <a.fatoum at barebox.org>

pstore_driver sets .type = filetype_uimage, likely copied from uimagefs.
pstore doesn't read from a device at all, so it shouldn't claim a type.

This is harmless so far, because file system detection never reports
uImages, but if it did, mounting a uImage without uimagefs enabled would
mount pstore instead. Let's drop the type. Startup code mounts pstore
with an explicit type, so it's not affected.

Assisted-by: Claude:opus-5.5
Signed-off-by: Ahmad Fatoum <a.fatoum at barebox.org>
---
 fs/pstore/fs.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/pstore/fs.c b/fs/pstore/fs.c
index 88951632138a..42825d01ce76 100644
--- a/fs/pstore/fs.c
+++ b/fs/pstore/fs.c
@@ -288,7 +288,6 @@ static const struct fs_legacy_ops pstore_ops = {
 
 static struct fs_driver pstore_driver = {
 	.legacy_ops = &pstore_ops,
-	.type = filetype_uimage,
 	.drv = {
 		.probe  = pstore_probe,
 		.remove = pstore_remove,
-- 
2.47.3




More information about the barebox mailing list