[PATCH 1/2] globalvar: propagate dev_set_param return value from globalvar_set

Ahmad Fatoum a.fatoum at pengutronix.de
Thu Mar 12 07:43:15 PDT 2026


dev_set_param() already returns an error code, which can be useful
for non-simple globalvars. Propagate it out of globalvar_set as well.

Signed-off-by: Ahmad Fatoum <a.fatoum at pengutronix.de>
---
 common/globalvar.c  | 4 ++--
 include/globalvar.h | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/common/globalvar.c b/common/globalvar.c
index 876379b2538e..c2b0d5b4bbad 100644
--- a/common/globalvar.c
+++ b/common/globalvar.c
@@ -456,9 +456,9 @@ void globalvar_set_match(const char *match, const char *val)
 	}
 }
 
-void globalvar_set(const char *name, const char *val)
+int globalvar_set(const char *name, const char *val)
 {
-	dev_set_param(&global_device, name, val);
+	return dev_set_param(&global_device, name, val);
 }
 
 static int globalvar_simple_set(struct bobject *bobj, struct param_d *p,
diff --git a/include/globalvar.h b/include/globalvar.h
index e369616c632a..413cf72002a0 100644
--- a/include/globalvar.h
+++ b/include/globalvar.h
@@ -22,7 +22,7 @@ int globalvar_add_simple(const char *name, const char *value);
 void globalvar_remove(const char *name);
 char *globalvar_get_match(const char *match, const char *separator);
 void globalvar_set_match(const char *match, const char *val);
-void globalvar_set(const char *name, const char *val);
+int globalvar_set(const char *name, const char *val);
 
 int globalvar_add_simple_string(const char *name, char **value);
 int globalvar_add_simple_int(const char *name, int *value,
@@ -124,7 +124,7 @@ static inline char *globalvar_get_match(const char *match, const char *separator
 
 static inline void globalvar_set_match(const char *match, const char *val) {}
 
-static inline void globalvar_set(const char *name, const char *val) {}
+static inline int globalvar_set(const char *name, const char *val) { return 0; }
 
 static inline int nvvar_load(void)
 {
-- 
2.47.3




More information about the barebox mailing list