[PATCH v2 2/7] serdev: add serdev_device_close

Marco Felsch m.felsch at pengutronix.de
Thu Feb 12 14:02:04 PST 2026


Add a cleanup helper which does the reverse operations of
serdev_device_open().

Signed-off-by: Marco Felsch <m.felsch at pengutronix.de>
---
 common/serdev.c  | 13 +++++++++++++
 include/serdev.h |  4 ++++
 2 files changed, 17 insertions(+)

diff --git a/common/serdev.c b/common/serdev.c
index 8f45c0a135237da42579bbb685c9c25a67428c8b..1c8cfbd59447afa86aa78c5b05b60e9057ebc15b 100644
--- a/common/serdev.c
+++ b/common/serdev.c
@@ -92,6 +92,8 @@ int serdev_device_open(struct serdev_device *serdev)
 		goto err_console_close;
 	}
 
+	serdev->polling_interval_param = p;
+
 	return 0;
 
 err_console_close:
@@ -106,6 +108,17 @@ int serdev_device_open(struct serdev_device *serdev)
 	return ret;
 }
 
+void serdev_device_close(struct serdev_device *serdev)
+{
+	struct console_device *cdev = to_console_device(serdev);
+
+	param_remove(serdev->polling_interval_param);
+	console_close(cdev);
+	poller_async_unregister(&serdev->poller);
+	kfifo_free(serdev->fifo);
+	free(serdev->buf);
+}
+
 unsigned int serdev_device_set_baudrate(struct serdev_device *serdev,
 					unsigned int speed)
 {
diff --git a/include/serdev.h b/include/serdev.h
index b402325f39a2458bf364d84ec1d9a5da6b829525..98704d8958d016426951a038a9a80fb05626febb 100644
--- a/include/serdev.h
+++ b/include/serdev.h
@@ -3,6 +3,7 @@
 #define _SERDEV_H_
 
 #include <driver.h>
+#include <param.h>
 #include <poller.h>
 #include <kfifo.h>
 
@@ -14,6 +15,7 @@
  * @buf:		Buffer used to pass Rx data to consumers
  * @poller		Async poller used to poll this serdev
  * @polling_interval:	Async poller periodicity
+ * @polling_interval_param:	Async poller periodicity barebox param_d
  * @polling_window:	Duration of a single busy loop poll
  * @locked:		Lock to prevent recursive polling
  * @receive_buf:	Function called with data received from device;
@@ -25,6 +27,7 @@ struct serdev_device {
 	unsigned char *buf;
 	struct poller_async poller;
 	uint64_t polling_interval;
+	struct param_d *polling_interval_param;
 	uint64_t polling_window;
 	bool locked;
 
@@ -33,6 +36,7 @@ struct serdev_device {
 };
 
 int serdev_device_open(struct serdev_device *);
+void serdev_device_close(struct serdev_device *);
 unsigned int serdev_device_set_baudrate(struct serdev_device *, unsigned int);
 int serdev_device_write(struct serdev_device *, const unsigned char *,
 			size_t, unsigned long);

-- 
2.47.3




More information about the barebox mailing list