[PATCH v2 9/9] test: py: add TLV integration tests

Jonas Rebmann jre at pengutronix.de
Mon Oct 13 03:53:32 PDT 2025


Hi Ahmad,

On 2025-10-13 12:35, Ahmad Fatoum wrote:
> On 10/7/25 11:12 AM, Ahmad Fatoum wrote:
>>> +from crcmod.predefined import mkPredefinedCrcFun
>>> +from .helper import skip_disabled
>>> +
>>> +_crc32_mpeg = mkPredefinedCrcFun("crc-32-mpeg")
> 
> This is unused, what's the point?
> 
> I will submit a patch for removal.

This indeed made it into my patch by mistake. It was supposed to be part
of the upcoming TLV signature integration tests in test/py/tset_tlv.py,
which I'll send this week.

There, I have tests with invalid signatures and valid CRCs for which I
need to fix CRCs after modifying the TLVs; hence the need for
_crc32_mpeg (which we also use in bareboxtlv-generator.py).

Regards,
Jonas

-- 
Pengutronix e.K.                           | Jonas Rebmann               |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-9    |



More information about the barebox mailing list