[PATCH] resource: replace wrong NULL check for dev_get_resource_by_name with IS_ERR
Ahmad Fatoum
a.fatoum at pengutronix.de
Mon May 5 23:21:59 PDT 2025
On error, dev_get_resource_by_name returns an error pointer, but a NULL
pointer was assumed instead erroneously.
Signed-off-by: Ahmad Fatoum <a.fatoum at pengutronix.de>
---
drivers/gpio/gpio-generic.c | 2 +-
drivers/video/rockchip/rockchip_drm_vop2.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-generic.c b/drivers/gpio/gpio-generic.c
index 1902c8396094..6164e87073bd 100644
--- a/drivers/gpio/gpio-generic.c
+++ b/drivers/gpio/gpio-generic.c
@@ -538,7 +538,7 @@ static int bgpio_dev_probe(struct device *dev)
return PTR_ERR(pdata);
r = dev_get_resource_by_name(dev, IORESOURCE_MEM, "dat");
- if (!r)
+ if (IS_ERR(r))
return -EINVAL;
sz = resource_size(r);
diff --git a/drivers/video/rockchip/rockchip_drm_vop2.c b/drivers/video/rockchip/rockchip_drm_vop2.c
index 0d6d31a86804..b49053c6e915 100644
--- a/drivers/video/rockchip/rockchip_drm_vop2.c
+++ b/drivers/video/rockchip/rockchip_drm_vop2.c
@@ -1958,7 +1958,7 @@ int vop2_bind(struct device *dev)
vop2->data = vop2_data;
res = dev_get_resource_by_name(dev, IORESOURCE_MEM, "vop");
- if (!res)
+ if (IS_ERR(res))
return dev_err_probe(vop2->dev, -EINVAL, "failed to get vop2 register byname\n");
vop2->regs = IOMEM(res->start);
--
2.39.5
More information about the barebox
mailing list