[RFC PATCH] fbconsole: add missing break
Sascha Hauer
s.hauer at pengutronix.de
Thu Mar 27 01:12:51 PDT 2025
On Tue, Mar 25, 2025 at 05:00:08PM +0100, Jules Maselbas wrote:
> The cursor move CSI has nothing to do with the clear-screen CSI.
CSI n K is erase to beginning or end of line.
> The existing fallthrough looks like a bug, add the missing break.
>
> Fixes: 27f79c05ab ("video: implement framebuffer console")
> Signed-off-by: Jules Maselbas <jmaselbas at zdiv.net>
> ---
>
> I am not 100% sure if this is a bug or not, it feels like it sould not
> fallthrough, an extra look would be nice.
Yes, really looks like a bug. Moving the cursor shouldn't erase
anything.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
More information about the barebox
mailing list