[PATCH 3/6] MAKEALL: fix check_pipe_status usage
Ahmad Fatoum
a.fatoum at pengutronix.de
Wed Mar 26 00:59:16 PDT 2025
When no logdir is specified, there is no shell pipeline to check the
status of and thus check_pipe_status will not check the status of the
just run command.
Fix this by placing check_pipe_status directly after the pipelines in
question.
Signed-off-by: Ahmad Fatoum <a.fatoum at pengutronix.de>
---
MAKEALL | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/MAKEALL b/MAKEALL
index a9409fbf7b07..85b71e2e75c1 100755
--- a/MAKEALL
+++ b/MAKEALL
@@ -101,9 +101,12 @@ with_logs_collected() {
if [ -n "${logdir}" ]; then
"$@" 2>&1 > "${log_report}" | tee "${log_err}"
+ check_pipe_status
else
"$@"
fi
+
+ return $?
}
report() {
@@ -169,7 +172,6 @@ do_build_defconfig() {
done
with_logs_collected ${MAKE} $silent_flag olddefconfig
- check_pipe_status
configure_result="$?"
report "Configure: "
@@ -178,8 +180,6 @@ do_build_defconfig() {
report "OK \n"
with_logs_collected ${MAKE} $silent_flag ${TARGET}
-
- check_pipe_status
compile_result="$?"
report "Compile: " ${defconfig}
@@ -230,8 +230,6 @@ do_test_defconfig() {
local err=0
LG_BUILDDIR=$BUILDDIR with_logs_collected pytest --lg-env $yaml "$@"
-
- check_pipe_status
compile_result="$?"
report "Test: " ${yaml}
--
2.39.5
More information about the barebox
mailing list