[RFC PATCH] fbconsole: add missing break
Jules Maselbas
jmaselbas at zdiv.net
Tue Mar 25 09:00:08 PDT 2025
The cursor move CSI has nothing to do with the clear-screen CSI.
The existing fallthrough looks like a bug, add the missing break.
Fixes: 27f79c05ab ("video: implement framebuffer console")
Signed-off-by: Jules Maselbas <jmaselbas at zdiv.net>
---
I am not 100% sure if this is a bug or not, it feels like it sould not
fallthrough, an extra look would be nice.
drivers/video/fbconsole.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/fbconsole.c b/drivers/video/fbconsole.c
index 24592d00ed..7462e34778 100644
--- a/drivers/video/fbconsole.c
+++ b/drivers/video/fbconsole.c
@@ -576,6 +576,7 @@ static void fbc_parse_csi(struct fbc_priv *priv)
priv->x = clamp(pos - 1, 0, (int) priv->cols - 1);
show_cursor(priv, priv->x, priv->y);
+ break;
case 'K':
pos = simple_strtoul(priv->csi, &end, 10);
video_invertchar(priv, priv->x, priv->y);
--
2.48.1
More information about the barebox
mailing list