[PATCH] common: fastboot: send FAIL if variable does not exist
Ahmad Fatoum
a.fatoum at pengutronix.de
Tue Jul 22 07:07:19 PDT 2025
Hello Andrei,
On 6/11/25 19:56, Andrei Lalaev wrote:
> According to doc [1], new implementations should send FAIL if the
> variable specified in the getvar command does not exist.
>
> [1]: https://android.googlesource.com/platform/system/core/+show/refs/heads/main/fastboot/README.md#121
>
> Signed-off-by: Andrei Lalaev <andrey.lalaev at gmail.com>
Did you run into any particular issues that motivated your change?
I am asking, because this causes error output for is-logical:$partition,
which barebox didn't implement.
I sent a patch to implement it, but would be good to know the backstory
on this patch. :)
Thanks,
Ahmad
> ---
> common/fastboot.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/fastboot.c b/common/fastboot.c
> index 56bc4e82c4..3df3c227a3 100644
> --- a/common/fastboot.c
> +++ b/common/fastboot.c
> @@ -372,7 +372,7 @@ static void cb_getvar(struct fastboot *fb, const char *cmd)
> goto out;
>
> skip_partitions:
> - fastboot_tx_print(fb, FASTBOOT_MSG_OKAY, "");
> + fastboot_tx_print(fb, FASTBOOT_MSG_FAIL, "");
> out:
> fastboot_free_variables(&partition_list);
> }
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
More information about the barebox
mailing list