[PATCH] clocksource: omit seeding of RNG in PBL

Ahmad Fatoum a.fatoum at pengutronix.de
Tue Apr 29 02:53:07 PDT 2025


Hello Sascha,

On 4/25/25 07:39, Sascha Hauer wrote:
> 
> On Thu, 24 Apr 2025 10:48:33 +0200, Ahmad Fatoum wrote:
>> We do not maintain a PRNG in the PBL, so we should omit the call to
>> srand_xor in PBL, otherwise it expands to BUG() and breaks the newly
>> introduced PBL clocksource support.
>>
>>
> 
> Applied, thanks!

While the patch is correct, I think it would be better to just drop the
BUG() in the header instead of littering IN_PROPER around.

If the patch isn't pushed yet, can you drop it?
I just sent out an alternative.

Thanks,
Ahmad

> 
> [1/1] clocksource: omit seeding of RNG in PBL
>       https://git.pengutronix.de/cgit/barebox/commit/?id=a6e031cc425d (link may not be stable)
> 
> Best regards,

-- 
Pengutronix e.K.                  |                             |
Steuerwalder Str. 21              | http://www.pengutronix.de/  |
31137 Hildesheim, Germany         | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |




More information about the barebox mailing list