[PATCH 10/18] cdev: implement devfs_create_link in terms of devfs_create

[Ahmad Fatoum]

devfs_create_link and devfs_create do much of the same things, so have
them share the code.

Signed-off-by: Ahmad Fatoum <a.fatoum at pengutronix.de>
---
 fs/devfs-core.c | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/fs/devfs-core.c b/fs/devfs-core.c
index 4c5445b17aaf..eb6691b5252b 100644
--- a/fs/devfs-core.c
+++ b/fs/devfs-core.c
@@ -422,15 +422,16 @@ int devfs_create(struct cdev *new)
 			new->device_node = new->dev->of_node;
 	}
 
+	if (new->link)
+		list_add_tail(&new->link_entry, &new->link->links);
+
 	return 0;
 }
 
 int devfs_create_link(struct cdev *cdev, const char *name)
 {
 	struct cdev *new;
-
-	if (cdev_by_name(name))
-		return -EEXIST;
+	int ret;
 
 	/*
 	 * Create a link to the real cdev instead of creating
@@ -441,6 +442,12 @@ int devfs_create_link(struct cdev *cdev, const char *name)
 	new = cdev_alloc(name);
 	new->link = cdev;
 
+	ret = devfs_create(new);
+	if (ret) {
+		cdev_free(new);
+		return ret;
+	}
+
 	if (cdev->partname) {
 		size_t partnameoff = 0;
 
@@ -454,11 +461,6 @@ int devfs_create_link(struct cdev *cdev, const char *name)
 		new->partname = xstrdup(name + partnameoff);
 	}
 
-	INIT_LIST_HEAD(&new->links);
-	INIT_LIST_HEAD(&new->partitions);
-	list_add_tail(&new->list, &cdev_list);
-	list_add_tail(&new->link_entry, &cdev->links);
-
 	return 0;
 }
 
-- 
2.39.5