[PATCH v4 05/16] crypto: Makefile: make simpler

[Ahmad Fatoum]

On 13.09.24 09:59, Sascha Hauer wrote:
> We have:
> 
> $(if $(RSA_DEP),$<,$(CONFIG_CRYPTO_RSA_KEY))
> 
> '$<' is the first dependency which is $(RSA_DEP). $(RSA_DEP) is either
> empty (in which case $(CONFIG_CRYPTO_RSA_KEY) is used), or set to
> $(CONFIG_CRYPTO_RSA_KEY) a few lines up.
> so all this is a complicated way of using $(CONFIG_CRYPTO_RSA_KEY)
> directly.
> 
> Signed-off-by: Sascha Hauer <s.hauer at pengutronix.de>

Reviewed-by: Ahmad Fatoum <a.fatoum at pengutronix.de>

> ---
>  crypto/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/crypto/Makefile b/crypto/Makefile
> index e84360a8c7..d7a06a721d 100644
> --- a/crypto/Makefile
> +++ b/crypto/Makefile
> @@ -34,5 +34,5 @@ RSA_DEP := $(CONFIG_CRYPTO_RSA_KEY)
>  endif
>  
>  $(obj)/rsa-keys.h: $(RSA_DEP) FORCE
> -	$(call cmd,public_keys,$(CONFIG_CRYPTO_RSA_KEY_NAME_HINT):$(if $(RSA_DEP),$<,$(CONFIG_CRYPTO_RSA_KEY)))
> +	$(call cmd,public_keys,$(CONFIG_CRYPTO_RSA_KEY_NAME_HINT):$(CONFIG_CRYPTO_RSA_KEY))
>  endif


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |