[PATCH 3/5] nvmem: constify the write path
Marco Felsch
m.felsch at pengutronix.de
Mon Mar 25 03:33:37 PDT 2024
On 24-03-25, Sascha Hauer wrote:
> On Fri, Mar 22, 2024 at 05:45:57PM +0100, Marco Felsch wrote:
> > Constify the nvmem_*_write() functions as the write functions shouldn't
> > alter the buffer content.
> >
> > Signed-off-by: Marco Felsch <m.felsch at pengutronix.de>
> > ---
> > drivers/nvmem/core.c | 10 +++++-----
> > include/linux/nvmem-consumer.h | 8 ++++----
> > 2 files changed, 9 insertions(+), 9 deletions(-)
> >
> > diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
> > index b4a29e4b67f3..7d795d5873dc 100644
> > --- a/drivers/nvmem/core.c
> > +++ b/drivers/nvmem/core.c
> > @@ -794,8 +794,8 @@ void *nvmem_cell_read(struct nvmem_cell *cell, size_t *len)
> > }
> > EXPORT_SYMBOL_GPL(nvmem_cell_read);
> >
> > -static inline void *nvmem_cell_prepare_write_buffer(struct nvmem_cell_entry *cell,
> > - u8 *_buf, int len)
> > +static inline const void *nvmem_cell_prepare_write_buffer(struct nvmem_cell_entry *cell,
> > + const u8 *_buf, int len)
>
> We already had this, this reverts a change you introduced with the nvmem
> update in patch 1. So better squash it into that patch.
Argh.. you're right, I will squash it. Thanks!
Regards,
Marco
>
> Sascha
>
> --
> Pengutronix e.K. | |
> Steuerwalder Str. 21 | http://www.pengutronix.de/ |
> 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
>
More information about the barebox
mailing list