[PATCH] fs: ramfs: simplify len calculation in ramfs_find_chunk

Ahmad Fatoum a.fatoum at pengutronix.de
Wed Jul 24 02:09:32 PDT 2024


ramfs_find_chunk finds the correct chunk and additionally returns via
argument pointers the offset to use and the remaining length.

While correct, the way the remaining len is calculated can be simplified
by using the offset previously calculated:

  data->ofs  +        data->size - pos
  data->size -  pos + data->ofs
  data->size - (pos - data->ofs)
  data->size - (*ofs)

Do that for clarity. No functional change.

Signed-off-by: Ahmad Fatoum <a.fatoum at pengutronix.de>
---
 fs/ramfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ramfs.c b/fs/ramfs.c
index 3223beba7212..a799b23efbcd 100644
--- a/fs/ramfs.c
+++ b/fs/ramfs.c
@@ -202,7 +202,7 @@ static struct ramfs_chunk *ramfs_find_chunk(struct ramfs_inode *node,
 	list_for_each_entry_from(data, &node->data, list) {
 		if (data->ofs + data->size > pos) {
 			*ofs = pos - data->ofs;
-			*len = data->ofs + data->size - pos;
+			*len = data->size - *ofs;
 
 			node->current_chunk = data;
 
-- 
2.39.2




More information about the barebox mailing list