[PATCH master] crypto: caam - remove overly verbose debug print
Sascha Hauer
sha at pengutronix.de
Wed Jan 3 03:20:51 PST 2024
On Tue, Jan 02, 2024 at 05:55:37PM +0100, Ahmad Fatoum wrote:
> We can already read /dev/hwrng to get the randomness as generated by the
> device. Printing 32K bytes of randomness to the log (or even worse to
> console) is just not useful for debugging. There are debug prints for
> the job descriptors and Linux doesn't have this print too since commit
> 2c5e88dc90f5 ("crypto: caam - simplify RNG implementation"), so let's
> drop it in barebox too.
>
> Signed-off-by: Ahmad Fatoum <a.fatoum at pengutronix.de>
> ---
> drivers/crypto/caam/caamrng.c | 3 ---
> 1 file changed, 3 deletions(-)
Applied, thanks
Sascha
>
> diff --git a/drivers/crypto/caam/caamrng.c b/drivers/crypto/caam/caamrng.c
> index ede35cea7f80..ea154913cab6 100644
> --- a/drivers/crypto/caam/caamrng.c
> +++ b/drivers/crypto/caam/caamrng.c
> @@ -91,9 +91,6 @@ static void rng_done(struct device *jrdev, u32 *desc, u32 err, void *context)
>
> /* Buffer refilled, invalidate cache */
> dma_sync_single_for_cpu(jrdev, bd->addr, RN_BUF_SIZE, DMA_FROM_DEVICE);
> -
> - print_hex_dump_debug("rng refreshed buf@: ", DUMP_PREFIX_OFFSET,
> - 16, 4, bd->buf, RN_BUF_SIZE, 1);
> }
>
> static inline int submit_job(struct caam_rng_ctx *ctx, int to_current)
> --
> 2.39.2
>
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
More information about the barebox
mailing list